feat(lsp): drop fswatch, use inotifywait #29374
Conversation
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
from
c0691c7
to
16ea529
Compare
|
The package |
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
from
16ea529
to
844093c
Compare
runtime/doc/news.txt
Outdated
| @@ -54,7 +54,9 @@ EVENTS | |||
|
|
|||
| LSP | |||
|
|
|||
| • TODO | |||
| • The watchfunc backend was implemented with fswatch, but deactivated by | |||
There was a problem hiding this comment.
Not sure if we need to mention this here since it was deactivated by default, and so it's not like a breaking change or anything.
There was a problem hiding this comment.
Where do I activate it by default? :-)
There was a problem hiding this comment.
Found it and enabled it.
There was a problem hiding this comment.
I don't think we want to enable it. Anything that uses inotify is going to have the same problems. It wasn't startup-time of fswatch that was the issue.
There was a problem hiding this comment.
What was the problem?
There was a problem hiding this comment.
Users kept hitting the limits of inotify and getting error messages.
Note libuv also uses inotify internally.
There was a problem hiding this comment.
I've removed it and improved the documentation.
However I think it should be documented how to enable inotify as watchfunc. I haven't found anything yet. Any suggestion where to do that?
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
from
844093c
to
c8f72b0
Compare
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
3 times, most recently
from
84f0337
to
30e95b2
Compare
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
from
30e95b2
to
3770c73
Compare
inotify-tools needs to be installed on the CI image, I'm not sure how to do that. Update: Might have found it. |
This patch replaces fswatch with inotifywait from inotify-toools: https://github.com/inotify-tools/inotify-tools fswatch takes ~1min to set up recursively for the Samba source code directory. inotifywait needs less than a second to do the same thing. emcrisostomo/fswatch#321 Also it fswatch seems to be unmaintained in the meantime. Signed-off-by: Andreas Schneider <[email protected]>
cryptomilk
force-pushed
the
asn-lsp-watchfunc
branch
from
3770c73
to
8823dce
Compare
justinmk
changed the title
justinmk
changed the title
This patch replaces fswatch with inotifywait from inotify-toools:
https://github.com/inotify-tools/inotify-tools
fswatch takes ~1min to set up recursively for the Samba source code directory. inotifywait needs less than a second to do the same thing.
emcrisostomo/fswatch#321
Also fswatch seems to be unmaintained in the meantime.