Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ui_busy_start()/ui_busy_stop() when search #29446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Shougo
Copy link
Contributor

@Shougo Shougo commented Jun 22, 2024

Fix #25980

I have removed gotocmdline() when search.
It resolves #25980 problem, but the side effect may exist.

I use ui_busy_start() and ui_busy_stop() instead.

@Shougo
Copy link
Contributor Author

Shougo commented Jun 22, 2024

Hm.... Vim has same feature but why it is not reproduced in Vim?

https://github.com/vim/vim/blob/7002c055d560ae0b3bb1e24ad409390a5443daad/src/search.c#L1567

@Shougo
Copy link
Contributor Author

Shougo commented Jun 22, 2024

I think the cursor is hidden when search in Vim.

cursor_on() and cursor_off() are implemented in Vim. But neovim is not.

@Shougo
Copy link
Contributor Author

Shougo commented Jun 22, 2024

It does not resolve the original problem.

Because other cursor movements are exists like this.

2024-06-22_11-45

I think neovim needs cursor_on() and cursor_off() like API.

@Shougo Shougo changed the title Remove gotocmdline() when search Use ui_busy_start()/ui_busy_end() when search Jun 22, 2024
@Shougo
Copy link
Contributor Author

Shougo commented Jun 22, 2024

OK. This fix is better.

@Shougo Shougo changed the title Use ui_busy_start()/ui_busy_end() when search Use ui_busy_start()/ui_busy_stop() when search Jun 22, 2024
@glepnir glepnir requested a review from bfredl June 22, 2024 06:29
@glepnir glepnir added the ui label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cursor moves to commandline when searching for pattern (perceived as cursor flicker)
2 participants