Skip to content

Commit

Permalink
fix(lspinfo)!: remove config.lspinfo
Browse files Browse the repository at this point in the history
Problem:
`config.lspinfo` is an undocumented feature that allows extending the
info shown in `:LspInfo` (`:checkhealth lspconfig`).
This feature is unwanted because:
- it's undocumented
- it adds a maintenance burden
- it provides info that should be derived from the LSP protocol itself.

Solution:
Remove support for `config.lspinfo`.
Instead, `:LspInfo` (`:checkhealth lspconfig`) should be enhanced to
automatically gather this kind of extra info from the server response.
  • Loading branch information
justinmk committed Oct 16, 2024
1 parent 541f3a2 commit c6abeba
Show file tree
Hide file tree
Showing 5 changed files with 1 addition and 30 deletions.
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ body:
- type: markdown
attributes:
value: |
Do NOT file bugs in this repo. The configs in this repo are unsupported and provided only as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and [send improvements](https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md).
The configs in this repo are UNSUPPORTED and provided only as a starting point. We depend on users (like you) to troubleshoot issues with their specific LSP setups and [send improvements](https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md).
If you have a feature request or found a bug in the core Nvim `vim.lsp` module (not this repo), [report it to Nvim](https://github.com/neovim/neovim/issues/new?assignees=&labels=bug%2Clsp&projects=&template=lsp_bug_report.yml).
- type: textarea
Expand Down
4 changes: 0 additions & 4 deletions doc/configs.md
Original file line number Diff line number Diff line change
Expand Up @@ -5592,10 +5592,6 @@ require'lspconfig'.hls.setup{}
```lua
{ "haskell", "lhaskell" }
```
- `lspinfo` :
```lua
see source file
```
- `root_dir` :
```lua
root_pattern("hie.yaml", "stack.yaml", "cabal.project", "*.cabal", "package.yaml")
Expand Down
4 changes: 0 additions & 4 deletions doc/configs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5592,10 +5592,6 @@ require'lspconfig'.hls.setup{}
```lua
{ "haskell", "lhaskell" }
```
- `lspinfo` :
```lua
see source file
```
- `root_dir` :
```lua
root_pattern("hie.yaml", "stack.yaml", "cabal.project", "*.cabal", "package.yaml")
Expand Down
16 changes: 0 additions & 16 deletions lua/lspconfig/configs/hls.lua
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,6 @@ return {
cabalFormattingProvider = 'cabalfmt',
},
},
lspinfo = function(cfg)
local extra = {}
local function on_stdout(_, data, _)
local version = data[1]
table.insert(extra, 'version: ' .. version)
end

local opts = {
cwd = cfg.cwd,
stdout_buffered = true,
on_stdout = on_stdout,
}
local chanid = vim.fn.jobstart({ cfg.cmd[1], '--version' }, opts)
vim.fn.jobwait { chanid }
return extra
end,
},

docs = {
Expand Down
5 changes: 0 additions & 5 deletions lua/lspconfig/health.lua
Original file line number Diff line number Diff line change
Expand Up @@ -174,11 +174,6 @@ local function make_client_info(client, fname)
'autostart: ' .. client_info.autostart,
}

if client.config.lspinfo then
local server_specific_info = client.config.lspinfo(client.config)
info_lines = vim.list_extend(info_lines, server_specific_info)
end

vim.list_extend(lines, info_lines)

return table.concat(lines, '\n')
Expand Down

0 comments on commit c6abeba

Please sign in to comment.