feat: ltex-ls-plus #3442
Open
feat: ltex-ls-plus #3442
+90
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 19, 2024
glepnir
reviewed
Nov 19, 2024
Comment on lines
+41
to
+50
| do | ||
| local enabled_keys = {} | ||
| for _, ft in ipairs(filetypes) do | ||
| local id = get_language_id({}, ft) | ||
| if not enabled_keys[id] then | ||
| enabled_keys[id] = true | ||
| table.insert(enabled_ids, id) | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
why you not inline these ids in settings ?
Comment on lines
+32
to
+39
| local function get_language_id(_, filetype) | ||
| local language_id = language_id_mapping[filetype] | ||
| if language_id then | ||
| return language_id | ||
| else | ||
| return filetype | ||
| end | ||
| end |
There was a problem hiding this comment.
Suggested change
| local function get_language_id(_, filetype) | |
| local language_id = language_id_mapping[filetype] | |
| if language_id then | |
| return language_id | |
| else | |
| return filetype | |
| end | |
| end | |
| local function get_language_id(_, filetype) | |
| return language_id_mapping[filetype] or filetype | |
| end |
There was a problem hiding this comment.
and inline the language_id_mapping in these function
There was a problem hiding this comment.
See #3442 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LTeX+, a popular fork of LTeX which, unlike LTeX, is actively maintained. It has over 4600 downloads on the VS Marketplace: https://marketplace.visualstudio.com/items?itemName=ltex-plus.vscode-ltex-plus