Skip to content

Conversation

mpgreaves
Copy link
Contributor

No description provided.

Signed-off-by: Michael Greaves <[email protected]>
Copy link

netlify bot commented Jul 17, 2025

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit b38b63e
🔍 Latest deploy log https://app.netlify.com/projects/nephio/deploys/6881fa4d8cf979000885ffec
😎 Deploy Preview https://deploy-preview-248--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

nephio-prow bot commented Jul 17, 2025

Hi @mpgreaves. Thanks for your PR.

I'm waiting for a nephio-project member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mpgreaves
Copy link
Contributor Author

/assign @efiacor @Catalin-Stratulat-Ericsson

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a couple of minor alterations.

* The Package Orchestration *engine*
The Package Orchestration *engine* implements the package lifecycle operations, and the package
mutation workflows.
* The *CaD Library*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The *CaD Library*

(the evaluation of a package's function *pipeline*), the initialization of a new package, and so
on. The CaD Library is shared with `kpt`, where it likewise provides the core package
manipulation algorithms.
* The *package cache*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The *package cache*

* The *repository adapters* for Git and OCI
The *repository adapters* implement the specific logic of interacting with those types of package
repositories.
* The *function runtime*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The *function runtime*

* The *package cache*
The *package cache* enables both local caching, as well as the abstract manipulation of packages
and their contents, irrespective of the underlying storage mechanism, such as Git, or OCI.
* The *repository adapters* for Git and OCI

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The *repository adapters* for Git and OCI

@Catalin-Stratulat-Ericsson
Copy link
Contributor

/ok-to-test

Co-authored-by: Catalin Stratulat <[email protected]>
Copy link

@Catalin-Stratulat-Ericsson
Copy link
Contributor

Catalin-Stratulat-Ericsson commented Oct 6, 2025

/approve

@efiacor
Copy link
Collaborator

efiacor commented Oct 9, 2025

/approve
/lgtm

@nephio-prow nephio-prow bot added the lgtm label Oct 9, 2025
Copy link
Contributor

nephio-prow bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Catalin-Stratulat-Ericsson, efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot added the approved label Oct 9, 2025
@nephio-prow nephio-prow bot merged commit b28d80d into nephio-project:main Oct 9, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants