Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPY-67: Added --no-cleanup flag to neptune sync to prevent cleanup of local logs after synchronization #1892

Draft
wants to merge 2 commits into
base: dev/1.x
Choose a base branch
from

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Dec 23, 2024

The current neptune sync architecture expects all containers to be synced to be moved to the async folder. Once the containers are synced, the local logs are deleted.

This change adds a --no-cleanup flag to neptune sync to prevent cleanup of local logs after synchronization,even though the logs will be moved to the async folder.

Running neptune sync --no-cleanup again deletes the local logs of already synced containers anyway from the async folder. Need help figuring this out (not a priority)

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@SiddhantSadangi SiddhantSadangi self-assigned this Dec 23, 2024
@SiddhantSadangi SiddhantSadangi changed the title Added --no-cleanup flag to neptune sync to prevent cleanup of local logs after synchronization PPY-67: Added --no-cleanup flag to neptune sync to prevent cleanup of local logs after synchronization Dec 23, 2024
@SiddhantSadangi SiddhantSadangi added this to the 1.14 milestone Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.61%. Comparing base (9747b21) to head (8af3d2c).

Files with missing lines Patch % Lines
src/neptune/cli/commands.py 25.00% 3 Missing ⚠️
src/neptune/cli/sync.py 77.77% 2 Missing ⚠️
src/neptune/cli/containers.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1892      +/-   ##
===========================================
- Coverage    77.60%   75.61%   -1.99%     
===========================================
  Files          303      303              
  Lines        15384    15373      -11     
===========================================
- Hits         11938    11624     -314     
- Misses        3446     3749     +303     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
macos 75.33% <82.85%> (-1.96%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.8 75.61% <82.85%> (-1.96%) ⬇️
py3.9 ?
ubuntu 75.48% <82.85%> (-1.96%) ⬇️
unit 75.61% <82.85%> (-0.03%) ⬇️
windows 74.52% <82.85%> (-1.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant