-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message for HTTPTooManyRequests #1895
base: dev/1.x
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.x #1895 +/- ##
===========================================
- Coverage 77.60% 75.57% -2.03%
===========================================
Files 303 303
Lines 15384 15372 -12
===========================================
- Hits 11938 11618 -320
- Misses 3446 3754 +308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/neptune/cli/containers.py
Outdated
def move(self, *, base_path: Path, target_container_id: UniqueId, container_type: ContainerType) -> None: | ||
elif ex.cause.__class__.__name__ == "HTTPTooManyRequests": | ||
warn_once( | ||
"Looks like you're reaching the default workspace logging-rate limit." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simplify slightly:
You're about to reach the default logging-rate limit for your workspace.
See how to optimize the logging calls to reduce requests: https://docs.neptune.ai/help/reducing_requests/
To increase the limit for your workspace, contact [email protected].
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Instead of "You're about to reach ...", I rephrased it to "You're hitting the ..." as this error is shown only one the limit has been breached.
Partially delivers #1893
Before submitting checklist