Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message for HTTPTooManyRequests #1895

Open
wants to merge 7 commits into
base: dev/1.x
Choose a base branch
from

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Dec 24, 2024

Partially delivers #1893

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 6 lines in your changes missing coverage. Please review.

Project coverage is 75.57%. Comparing base (9747b21) to head (c71be1c).
Report is 1 commits behind head on dev/1.x.

Files with missing lines Patch % Lines
src/neptune/cli/containers.py 76.92% 3 Missing ⚠️
src/neptune/internal/threading/daemon.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.x    #1895      +/-   ##
===========================================
- Coverage    77.60%   75.57%   -2.03%     
===========================================
  Files          303      303              
  Lines        15384    15372      -12     
===========================================
- Hits         11938    11618     -320     
- Misses        3446     3754     +308     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
macos 75.31% <66.66%> (-1.99%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.8 75.57% <66.66%> (-1.99%) ⬇️
py3.9 ?
ubuntu 75.44% <66.66%> (-1.99%) ⬇️
unit 75.57% <66.66%> (-0.06%) ⬇️
windows 74.49% <66.66%> (-1.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SiddhantSadangi SiddhantSadangi requested review from a team and removed request for PatrykGala and kgodlewski December 24, 2024 21:01
def move(self, *, base_path: Path, target_container_id: UniqueId, container_type: ContainerType) -> None:
elif ex.cause.__class__.__name__ == "HTTPTooManyRequests":
warn_once(
"Looks like you're reaching the default workspace logging-rate limit."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To simplify slightly:
You're about to reach the default logging-rate limit for your workspace.
See how to optimize the logging calls to reduce requests: https://docs.neptune.ai/help/reducing_requests/
To increase the limit for your workspace, contact [email protected].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Instead of "You're about to reach ...", I rephrased it to "You're hitting the ..." as this error is shown only one the limit has been breached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Better error message when usage limit arrived. (HTTPTooManyRequests)
2 participants