Merge pull request #86 from nerds-and-company/plugin_database_update_fix

Don't care about instable plugin database update outcome
nerds-and-company · Mar 8, 2017 · 7f4e3a4 · 7f4e3a4
2 parents 98f6003 + 5010774
commit 7f4e3a4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 16 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+###3.6.1###
+- Don't care about instable plugin database update outcome
+
 ###3.6.0###
 - Delete old blocktypes from matrixfields on force. (thanks to @Zae)
 - Beware backwards compatibility for the custom Field Models. There is now a $force parameter on the populate method.

diff --git a/src/Services/Plugins.php b/src/Services/Plugins.php
@@ -93,21 +93,6 @@ protected function togglePluginByHandle($handle, $isEnabled)
         }
     }
 
-    /**
-     * Run plugin migrations automatically.
-     *
-     * @param string $handle
-     *
-     * @throws Exception
-     */
-    protected function runMigrations($handle)
-    {
-        $result = $this->getUpdatesService()->updateDatabase($handle);
-        if (!$result['success']) {
-            $this->addError($result['message']);
-        }
-    }
-
     /**
      * @param BasePlugin $plugin
      *
@@ -152,7 +137,7 @@ public function import(array $pluginDefinitions, $force = false)
                     $this->togglePluginByHandle($handle, $pluginDefinition['isEnabled']);
 
                     if (!$isNewPlugin && $plugin->isEnabled) {
-                        $this->runMigrations($handle);
+                        $this->getUpdatesService()->updateDatabase($handle);
                     }
 
                     if (array_key_exists('settings', $pluginDefinition)) {