Skip to content

Commit

Permalink
Merge pull request #92 from nerds-and-company/remove_asset_transform_…
Browse files Browse the repository at this point in the history
…dimension_change_time

Removed Asset Transform dimensionChangeTime attribute from schema
  • Loading branch information
Bob Olde Hampsink committed Apr 13, 2017
2 parents b147194 + 2a7a571 commit ea1049b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
###3.7.1###
- Removed Asset Transform dimensionChangeTime attribute from schema

###3.7.0###
- Added support for importing/exporting Asset Transforms
- Asset Sources now respect the force option
Expand Down
2 changes: 0 additions & 2 deletions src/Services/AssetTransforms.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ private function getAssetTransformDefinition(AssetTransformModel $assetTransform
'width' => $assetTransform->width,
'height' => $assetTransform->height,
'format' => $assetTransform->format,
'dimensionChangeTime' => $assetTransform->dimensionChangeTime,
'mode' => $assetTransform->mode,
'position' => $assetTransform->position,
'quality' => $assetTransform->quality,
Expand Down Expand Up @@ -122,7 +121,6 @@ private function populateAssetTransform(AssetTransformModel $assetTransform, arr
'width' => $assetTransformDefinition['width'],
'height' => $assetTransformDefinition['height'],
'format' => $assetTransformDefinition['format'],
'dimensionChangeTime' => $assetTransformDefinition['dimensionChangeTime'],
'mode' => $assetTransformDefinition['mode'],
'position' => $assetTransformDefinition['position'],
'quality' => $assetTransformDefinition['quality'],
Expand Down
4 changes: 0 additions & 4 deletions tests/Services/AssetTransformsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ public function provideValidAssetTransforms()
'width' => null,
'height' => null,
'format' => null,
'dimensionChangeTime' => null,
'mode' => null,
'position' => null,
'quality' => null,
Expand All @@ -126,7 +125,6 @@ public function provideValidAssetTransforms()
'width' => null,
'height' => null,
'format' => null,
'dimensionChangeTime' => null,
'mode' => null,
'position' => null,
'quality' => null,
Expand All @@ -136,7 +134,6 @@ public function provideValidAssetTransforms()
'width' => null,
'height' => null,
'format' => null,
'dimensionChangeTime' => null,
'mode' => null,
'position' => null,
'quality' => null,
Expand All @@ -162,7 +159,6 @@ public function provideValidAssetTransformDefinitions()
'width' => 100,
'height' => 100,
'format' => 'jpg',
'dimensionChangeTime' => null,
'mode' => 'crop',
'position' => 'center-center',
'quality' => 75,
Expand Down

0 comments on commit ea1049b

Please sign in to comment.