Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clip prop #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add clip prop #143

wants to merge 1 commit into from

Conversation

nerdyman
Copy link
Owner

@nerdyman nerdyman commented Apr 11, 2024 •
edited
Loading

@nerdyman nerdyman self-assigned this Apr 11, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-compare-slider ✅ Ready (Inspect) Visit Preview Apr 11, 2024 5:11pm

@nerdyman nerdyman added the enhancement New feature or request label Apr 11, 2024
@nerdyman nerdyman linked an issue Apr 11, 2024 that may be closed by this pull request
Add support for clipping imageOne #136
Open
@zoltan-mihalyi
Copy link

Hi! Is this PR still in progress?

Are you planning to implement the three way switch?
#137 (comment)

@nerdyman
Copy link
Owner Author

Apologies @zoltan-mihalyi! Yeah still planning on doing the three way switch. I'll take a look this weekend.

@nerdyman
Copy link
Owner Author

nerdyman commented May 20, 2024 •
edited
Loading

@zoltan-mihalyi This will need a major release since it changes the underlying markup. I also found a few issues with the current clip behaviour. ContainerClip uses absolute positioning which causes the slider lose its intrinsic sizing when both items are clipped which isn't ideal. I was looking at replacing the absolute positioning with overlapping grid items in the next release so I can do that as part of this PR.

If you need this feature ASAP I can publish a pre-release version for you to use? Just keep in mind there will be changes in the final v4 release.

@zoltan-mihalyi
Copy link

Thank you for informing!
Is the problem that you described relevant in the three-way switch or in the version merged to next branch too?

Very kind of you, I have a workaround for now, but in the long therm it would be nice to use the upstream version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nerdyman nerdyman

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for clipping imageOne
2 participants
@nerdyman @zoltan-mihalyi