Fix dimension mismatch between downscaled cameras and images in colmap. #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb-ye
approved these changes
Jun 16, 2024
jb-ye
force-pushed
the
jisung3d/fix-downscaling-colmap
branch
from
7e0b6b9
to
3fec6ad
Compare
jb-ye
force-pushed
the
jisung3d/fix-downscaling-colmap
branch
from
3fec6ad
to
e070a05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When running
splatfactowith my custom dataset of images with varying resolutions, I encountered a dimension mismatch error between the downscaled cameras and images. This issue arises because the_downscale_imagesfunction incolmap_dataparser.py(L484) uses a fixed downscaling size for every image.Proposed Solution: Modify
_downscale_imagesto compute the downscaling size individually for each image to ensure compatibility with images of different resolutions.