Skip to content

chore(CI): Checkout pr branch when event is issue_comment #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

chore(CI): Checkout pr branch when event is issue_comment #2754

merged 1 commit into from
Jul 4, 2023

Conversation

@yanguoyu
Copy link
Contributor

@yanguoyu yanguoyu commented Jun 30, 2023 •
edited
Loading

Because the outputs.ref is the fork repo's branch name. So we should add the repo parameter for checkout action when the event is issue_comment.

Examples:
Trigger by push: https://github.com/yanguoyu/neuron/actions/runs/5419801750
Trigger by issue_comment with current repo: pr, action: https://github.com/yanguoyu/neuron/actions/runs/5441117221
Trigger by issue_comment with fork repo: pr, action: https://github.com/yanguoyu/neuron/actions/runs/5441115012

@yanguoyu yanguoyu mentioned this pull request Jun 30, 2023
Closed
@yanguoyu yanguoyu enabled auto-merge June 30, 2023 08:15
@Keith-CY
Copy link
Collaborator

Keith-CY commented Jul 2, 2023

https://github.com/alessbell/pull-request-comment-branch is not actively maintained and falls behind its original one.

Can we fork and maintain one forked from https://github.com/xt0rted/pull-request-comment-branch, and propose the feature we desired to https://github.com/xt0rted/pull-request-comment-branch

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jul 3, 2023

https://github.com/alessbell/pull-request-comment-branch is not actively maintained and falls behind its original one.

Can we fork and maintain one forked from https://github.com/xt0rted/pull-request-comment-branch, and propose the feature we desired to https://github.com/xt0rted/pull-request-comment-branch

xt0rted/pull-request-comment-branch#356 Someone has created a pull request for this. But the repo owner hasn't dealt with it yet.

@Keith-CY
Copy link
Collaborator

Keith-CY commented Jul 3, 2023 •
edited
Loading

alessbell/pull-request-comment-branch is not actively maintained and falls behind its original one.
Can we fork and maintain one forked from xt0rted/pull-request-comment-branch, and propose the feature we desired to xt0rted/pull-request-comment-branch

xt0rted/pull-request-comment-branch#356 Someone has created a pull request for this. But the repo owner hasn't dealt with it yet.

Got it, if it is possible to fork xt0rted/pull-request-comment-branch#356 and adopt updates from alessbell/pull-request-comment-branch, and keep the forked repo synced periodically.

The main problem of alessbell/pull-request-comment-branch is that it's not actively maintained

@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jul 3, 2023

alessbell/pull-request-comment-branch is not actively maintained and falls behind its original one.
Can we fork and maintain one forked from xt0rted/pull-request-comment-branch, and propose the feature we desired to xt0rted/pull-request-comment-branch

xt0rted/pull-request-comment-branch#356 Someone has created a pull request for this. But the repo owner hasn't dealt with it yet.

Got it, if it is possible to fork xt0rted/pull-request-comment-branch#356 and adopt updates from alessbell/pull-request-comment-branch, and keep the forked repo synced periodically.

The main problem of alessbell/pull-request-comment-branch is that it's not actively maintained

Gotcha, I will try.

@yanguoyu yanguoyu force-pushed the test-fork-package branch from d044e68 to a077b96 Compare July 3, 2023 05:16
@yanguoyu yanguoyu marked this pull request as draft July 3, 2023 05:29
auto-merge was automatically disabled July 3, 2023 05:29

Pull request was converted to draft

@yanguoyu yanguoyu force-pushed the test-fork-package branch 2 times, most recently from 3ffdf55 to ae7eb69 Compare July 3, 2023 06:00
@yanguoyu yanguoyu marked this pull request as ready for review July 3, 2023 06:35
@yanguoyu
Copy link
Contributor Author

yanguoyu commented Jul 3, 2023

@Keith-CY @homura @WhiteMinds Please have a review

homura
homura reviewed Jul 3, 2023
View reviewed changes
Keith-CY
Keith-CY reviewed Jul 3, 2023
View reviewed changes
@yanguoyu yanguoyu force-pushed the test-fork-package branch from ae7eb69 to 788872a Compare July 4, 2023 04:45
@Keith-CY Keith-CY added this pull request to the merge queue Jul 4, 2023
Merged via the queue into nervosnetwork:develop with commit 6b16aed Jul 4, 2023
@yanguoyu yanguoyu deleted the test-fork-package branch July 4, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

+4 more reviewers

@homura homura homura approved these changes

@WhiteMinds WhiteMinds WhiteMinds approved these changes

@devchenyan devchenyan devchenyan approved these changes

@alexsupa597 alexsupa597 alexsupa597 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yanguoyu @Keith-CY @homura @WhiteMinds @devchenyan @alexsupa597