Skip to content

fix: fix spawn split#425

Merged
driftluo merged 1 commit intomasterfrom
fix-spawn-split
Mar 7, 2026
Merged

fix: fix spawn split#425
driftluo merged 1 commit intomasterfrom
fix-spawn-split

Conversation

@driftluo
Copy link
Collaborator

@driftluo driftluo commented Mar 6, 2026

When is_readable is true, it will decode from the read buffer.
https://github.com/tokio-rs/tokio/blob/master/tokio-util/src/codec/framed_impl.rs#L183

But FramedRead::new always sets is_readable to false. So, read buffer replace will never be used unless it reads the second message from StreamHandle.

Now, let's build the split differently, preserving its internal state.

@driftluo driftluo requested a review from eval-exec as a code owner March 6, 2026 09:32
@driftluo driftluo merged commit fbd0f99 into master Mar 7, 2026
7 checks passed
@driftluo driftluo deleted the fix-spawn-split branch March 7, 2026 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants