Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications not being shown on modern Androids #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

di72nn
Copy link

@di72nn di72nn commented Jan 18, 2020

Hi!

Since targetSdkVersion 26 notifications without a notification channel are not shown on Android 8+ (see this).

This PR adds two notification channels: sync for silent sync notifications and noisy default for everything else.

@di72nn
Copy link
Author

di72nn commented Mar 18, 2020

@nerzhul
Just a friendly reminder that to have notifications working on modern Androids you need to merge this (or implement a fix yourself).

Let me know if you want me to improve the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant