Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

krainboltgreene
Copy link
Collaborator

So this started off as me just implementing that logger change, but ended up as a major refactor. I didn't start off with this in mind but I think it's something that'll be good for anyone using dante, with the following being the most important:

  1. No more internal logging code.
  2. No more internal PID management
  3. No more erb or yaml requirements (Not sure why they're even required?)
  4. Smaller surface to test.
  5. Easier time inheriting the core class for custom daemon classes.

Some things still left to be done:

  1. Pid file management, probably with https://github.com/samullen/pidfile
  2. User/group management
  3. Some default tests, maybe
  4. Built in stop/start/restart commands?

@Paxa
Copy link

Paxa commented Aug 25, 2014

Looks good, I wish it would be merged

@leucos
Copy link

leucos commented Sep 14, 2014

👍

@bdandy
Copy link

bdandy commented Oct 23, 2014

Yeah, looks nice!

@bdandy
Copy link

bdandy commented Nov 4, 2014

@nesquena, will you accept this pull request?

@nesquena
Copy link
Owner

nesquena commented Nov 4, 2014

I haven't looked at dante in a long while but sure I will merge this in, sorry it took so long. If anyone wants to help out as a contributor / maintainer for dante, I'd certainly appreciate the help.

@krainboltgreene
Copy link
Collaborator Author

I now manage hamstergem/hamster, I don't mind maintaining another gem.

@nesquena
Copy link
Owner

nesquena commented Nov 4, 2014

Great, I've added you as a collaborator for dante. Appreciate you stepping in.

@mkonikowski
Copy link

Is this project alive? Any updates on the status of this PR?

@krainboltgreene
Copy link
Collaborator Author

Semi-sortive? My initial goal was to revamp dante, but frankly with the
advent of things like systemd it seems like dante really isn't needed.

There are better CLI frameworks (clamp, commander) and there are easier to
use process management tools now (upstart, systemd, launchctl).

Frankly dante.gem is old.

On Fri, Jun 26, 2015 at 3:40 AM, Mateusz Konikowski <
[email protected]> wrote:

Is this project alive? Any updates on the status of this PR?


Reply to this email directly or view it on GitHub
#12 (comment).

Kurtis Rainbolt-Greene, Hacker
Software Developer
1631 8th St.
New Orleans, LA
70115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants