fix: wait for model catalog before opening picker#1747
Merged
1 commit merged intonesquena:masterfrom May 6, 2026
Merged
Conversation
This was referenced May 6, 2026
9900248
pull Bot
pushed a commit
to soitun/hermes-webui
that referenced
this pull request
May 6, 2026
…-color meta, quote-strip) + test-isolation hardening (nesquena#1746 deferred) Constituent PRs: - nesquena#1747 (@Michaelyklam) — wait for model catalog before opening picker (closes nesquena#1743) - nesquena#1748 (@nesquena-hermes) — theme-color meta tag for native chrome bridges (nesquena APPROVED) - nesquena#1750 (@nesquena-hermes) — strip surrounding quotes from Add Space path (nesquena APPROVED) Deferred to v0.51.12: - nesquena#1746 — Opus caught multiprocessing.Queue deadlock pattern (parent process.join() before queue drain hangs on output >64KB pipe buffer). Deferral comment with two specific fix options posted on PR. Plus 1 in-stage absorbed test-isolation fix: - test_issue1426 + test_issue1680: skip on detected prefix pollution (prong 2 of test-isolation-flake-recipe). Failure rate ~25% in full suite from sys.modules pollution; standalone always passes. Tests: 4596 → 4622 passing (+26). 0 regressions. Stably green. Pre-release verification: - 3 PRs CI-green individually + rebased onto master - pytest 4622 passed, 0 failed - node -c clean on static/ui.js + static/boot.js - 11/11 browser API endpoints PASS - Opus advisor: SHIP nesquena#1747/nesquena#1748/nesquena#1750, MUST-FIX block on nesquena#1746 Closes nesquena#1743.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
<select>plus a visible custom dropdown./api/modelscan correctly return OpenAI Codex models while the visible dropdown still renders the static HTML fallback if it opens before async model hydration finishes.window._modelDropdownReadybefore first render, and re-render if hydration completes while the picker is already open.What Changed
toggleModelDropdown()async and waits forwindow._modelDropdownReadybefore callingrenderModelDropdown().populateModelDropdown()replaces the hidden<select>when the picker is already open.Why It Matters
Fixes #1743.
Verification
tests/test_issue1743_model_picker_race.pyfailed before implementation with missing async wait/re-render assertions./home/michael/.hermes/hermes-agent/venv/bin/python -m pytest tests/test_issue1743_model_picker_race.py tests/test_ollama_model_chip_label_regression.py tests/test_byok_model_dropdown.py tests/test_model_picker_badges.py tests/test_issue1567_nous_picker_capacity_and_symmetry.py -q→48 passed in 11.33senv -u HERMES_CONFIG_PATH -u HERMES_WEBUI_HOST /home/michael/.hermes/hermes-agent/venv/bin/python -m pytest tests/ -q→4598 passed, 2 skipped, 3 xpassed, 1 warning, 8 subtests passed in 382.74sgit diff --checkpassed.toggleModelDropdown()waits on a delayedwindow._modelDropdownReadybefore opening.Configured,Gemini,OpenAI Codex, andOpenRoutergroups with Codex rows such asGPT 5.5,GPT 5.4,GPT 5.3 Codex, andGPT 5.3 Codex Spark.Risks / Follow-ups
window._modelDropdownReadycan delay first dropdown open by the/api/modelsrequest duration, but avoids showing an incorrect catalog. If/api/modelsfails, the existing promise catches and the static fallback remains available.Model Used
gpt-5.5