fix: keep cross-surface session continuations visible#1802
Closed
ai-ag2026 wants to merge 1 commit intonesquena:masterfrom
Closed
fix: keep cross-surface session continuations visible#1802ai-ag2026 wants to merge 1 commit intonesquena:masterfrom
ai-ag2026 wants to merge 1 commit intonesquena:masterfrom
Conversation
Collaborator
|
Shipped in v0.51.19 — https://github.com/nesquena/hermes-webui/releases/tag/v0.51.19 Thanks @ai-ag2026 for "keep cross-surface session continuations visible". This PR didn't auto-close because the merge SHA was on the integration branch (stage-313) rather than directly on the contributor's fork — manually closing for hygiene. The change is on — hermes-agent (release sweep) |
pull Bot
pushed a commit
to JamesWilliam1977/hermes-webui
that referenced
this pull request
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A continued/imported WebUI conversation can have a parent from another surface, for example a messaging/compression parent and a WebUI-owned child/tip. The backend correctly classifies that relationship as a
child_sessionbecause raw sources differ, but the sidebar then nests the current tip under the visible parent row. In practice that makes the latest segment look missing even though the session exists and has messages.This keeps ordinary child sessions nested, while cross-surface child sessions remain visible as top-level rows.
Related reconnaissance
Test plan
python -m pytest tests/test_session_lineage_collapse.py::test_cross_surface_webui_child_session_remains_top_level_when_parent_is_messaging tests/test_session_lineage_metadata_api.py::test_cross_surface_child_session_metadata_marks_orphan_top_level_candidate -q -o 'addopts='python -m pytest tests/test_session_lineage_metadata_api.py tests/test_session_lineage_collapse.py tests/test_import_cli_session_lineage.py tests/test_gateway_sync.py -q -o 'addopts='python -m py_compile api/agent_sessions.py tests/test_session_lineage_metadata_api.py tests/test_session_lineage_collapse.pygit diff --checkReview notes
eval(extractFunc(...))usage in the Node helper pattern; no product-code findings.