Merge pull request #1105 from kitimark/fix-media-query-style-loss-test

test: fix media query style is lost when it's compiled
nest-modules · Feb 13, 2024 · 13ed63d · 13ed63d
2 parents 5d90fc8 + 4f79d29
commit 13ed63d
Show file tree

Hide file tree

Showing 5 changed files with 97 additions and 10 deletions.
diff --git a/README.md b/README.md
@@ -60,6 +60,7 @@ you can find all the documentation [here](https://nest-modules.github.io/mailer/
 * [Juan Echeverry](https://github.com/juandav)
 * [Pat McGowan](https://github.com/p-mcgowan)
 * [Paweł Partyka](https://github.com/partyka95)
+* [Wasutan Kitijerapat](https://github.com/kitimark)
 
 ### License
 

diff --git a/lib/mailer.service.spec.ts b/lib/mailer.service.spec.ts
@@ -286,7 +286,7 @@ describe('MailerService', () => {
       '@media only screen and (max-width:350px)',
     );
     expect(lastMail.data.html?.toString().replace(/\n/g, '')).toContain(
-      `<html><head><style type=\"text/css\">@media only screen and (max-width:350px) {  p {    font-size: 20px;  }}</style></head><body><p>Handlebars test template. by Nest-modules TM</p></body></html>`.replace(/\n/g, ''),
+      `<html><head><style data-css-inline=\"keep\" type=\"text/css\">  @media only screen and (max-width:350px) { p { font-size: 20px; } }</style></head><body><p>Handlebars test template. by Nest-modules TM</p></body></html>`
     );
   });
 

diff --git a/lib/test-templates/handlebars-template-media-query.hbs b/lib/test-templates/handlebars-template-media-query.hbs
@@ -1,4 +1,4 @@
-<style type='text/css'>
+<style data-css-inline="keep" type='text/css'>
   @media only screen and (max-width:350px) { p { font-size: 20px; } }
 </style>
 

diff --git a/package.json b/package.json
@@ -52,7 +52,7 @@
     ]
   },
   "dependencies": {
-    "@css-inline/css-inline": "0.12.1",
+    "@css-inline/css-inline": "0.13.0",
     "glob": "10.3.10",
     "mjml": "4.14.1",
     "preview-email": "3.0.19"

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml