Refactor code in NEST Server #3319
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrensch
added
S: Normal
babsey
changed the title
babsey
added
the
P: Blocked
Contributor
|
@babsey, could you add a comment why this is blocked? |
Contributor
Author
|
Close because of clean PR #3411 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors code to better coding structure because I always lost the overview of the old
hl_api_serverfile.Each file has clear definition:
hl_api_server: Main file with flask routes and flask configurations (app).hl_api_server_helpers: Helper code (objects, functions) for the main file (withoutflaskdeps).hl_api_server_utils: General code, similar to helpers but withoutnestimports.hl_api_server_mpi: It includes MPI codes.