Bump C++ standard to C++20 #3581
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cular include chains
Co-authored-by: Dennis Terhorst <[email protected]>
Co-authored-by: Dennis Terhorst <[email protected]> (cherry picked from commit cd6271f)
(cherry picked from commit 9884718)
(cherry picked from commit 076e11a)
(cherry picked from commit 0313d49)
# Conflicts: # nestkernel/layer.h
# Conflicts: # models/correlomatrix_detector.cpp # nestkernel/connection_manager.cpp # nestkernel/model_manager.cpp # nestkernel/model_manager.h # nestkernel/nest.cpp # nestkernel/node_manager.cpp # nestkernel/simulation_manager.cpp # nestkernel/source_table.cpp # nestkernel/sp_manager.cpp # nestkernel/spatial.cpp # nestkernel/target_identifier.h
jessica-mitchell
added
S: Critical
jessica-mitchell
added
S: High
JanVogelsang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of two changes:
requireskeyword) that this PR uses tofiximprove the timer implementation.FixImprove the detailed and threaded timer implementation by now correctly turning off detailed or threaded timers when desired.The PR is based on #3544, which should be merged first. After #3544 is fixed, the number of changes in this PR will reduce drastically.
Edit: #3582 already fixed the timer issue, but the changes to the stopwatches here might still be more desirable compared to the solution implemented in #3582.
Now that the timer issue is already fixed, we can take more time to improve other aspects, such as the CMake-to-C++ interface, which is currently mainly C-macro-based. This could be changed to a C++-based solution which uses compile-time constants (
constexpr) instead of C-macros. Further, C++20 modules could be introduced to further cut compile times and clean up the include tree (in combination with #3544).