feat: add glob pattern matching for env files #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Papooch
reviewed
Sep 30, 2024
There was a problem hiding this comment.
You might want to update the docstring in the options interface with a mention of supporting globs, too.
| @@ -20,6 +20,7 @@ | |||
| "dependencies": { | |||
| "dotenv": "16.4.5", | |||
| "dotenv-expand": "10.0.0", | |||
| "glob": "^11.0.0", | |||
There was a problem hiding this comment.
You added a dependency to package.json, but did not commit the updated package-lock.json, so the tests are failing on CI. Please add the lock file.
| @@ -19,6 +19,7 @@ import { ConfigFactoryKeyHost } from './utils'; | |||
| import { createConfigProvider } from './utils/create-config-factory.util'; | |||
| import { getRegistrationToken } from './utils/get-registration-token.util'; | |||
| import { mergeConfigObject } from './utils/merge-configs.util'; | |||
| import { globSync } from 'glob'; | |||
There was a problem hiding this comment.
Imports should be sorted by scoped->unscoped->relative, and alphabetically. (in VSCode, there's a command called "Organize Imports" - Shift+Alt+O)
|
You can just run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The envFilePath only supports matching specific paths, which becomes cumbersome when trying to match multiple paths.
Issue Number: N/A
What is the new behavior?
Use glob pattern matching for paths. For example:
envFilePath: ".env*"can match .env, .env.local, .env.production, etc.Does this PR introduce a breaking change?
Other information