Allow subscriptions in the apollo federation driver #3682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Currently all subscriptions are disabled when using the apollo federation driver. There is no reason to disable them, they work perfectly fine, and even though Apollo's GraphOS is an enterprise offering, solutions such as Wundergraph Cosmo can use them.
Issue Number:
#2879
nestjs/nest#11987
and many others
What is the new behavior?
Now we allow subscriptions to function just like the existing Apollo Driver.
Does this PR introduce a breaking change?
Other information
I know this is an absolute dealbreaker for my own org, and based on the responses in the linked issues, i'm sure many other people feel the same way.
If the maintainer will allow such a change, I can continue making some tests / etc. I have verified that doing this change results in a perfectly operable subgraph with subscriptions.