feat(ws): add regex path support on platform ws path #13403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently Websocket Adaptor only takes strict pathname as parameter but common use case like YJS works on random websocket route
/ws/:room_id
which makes it hard nest js to be used in those scenario. This PR will help fixing that use case.Issue Number: N/A
What is the new behavior?
Websocket Adaptor
path
parameter can now take pathregex as input likews/:room_id
and it will allow request url which match that pathregex.Does this PR introduce a breaking change?
Other information
I tried running integration test on my local system with docker up but still there were few failing tests for me. I'm new to mocha ( have use jest ) ws-gateway, rpc integration are failing for me even if I roll back my changes. I ran ws-gateway test cases individually as it was not dependent on any docker container with this command
npx mocha --watch integration/websockets/e2e/ws-gateway.spec.ts