Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #13683

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

ragavendra
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
e2e test app.e2e-spec.ts has chai dependency which was not available in package,json.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • [x ] Other... Please describe:
    Added chai to dev dependencies. Using 4.3.9 for chai as the latest version gives import error for expect.

What is the current behavior?

npm run test:e2e fails when running test in app.e2e-spec.ts on import { expect } from "chai"

Issue Number: N/A

What is the new behavior?

npm run test:e2e now passes.

Does this PR introduce a breaking change?

  • Yes
  • [ x] No

Other information

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 99eda344-75c9-4f7b-b0fe-46b7084b4540

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.207%

Totals Coverage Status
Change from base Build e18002f5-8ff6-4564-ba7e-328984ab8501: 0.0%
Covered Lines: 6744
Relevant Lines: 7314

💛 - Coveralls

@micalevisk
Copy link
Member

micalevisk commented Jun 14, 2024

instead of installing chai, we can just drop line 3 and change those to.equal to toEqual

import { expect } from 'chai';

No need for chai as assertions can be done without it.
Copy link
Member

@micalevisk micalevisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we don't need to change the lock file tho

@coveralls
Copy link

coveralls commented Jun 14, 2024

Pull Request Test Coverage Report for Build 256be342-8225-4e00-a8fe-64821a0665c7

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.207%

Totals Coverage Status
Change from base Build e18002f5-8ff6-4564-ba7e-328984ab8501: 0.0%
Covered Lines: 6744
Relevant Lines: 7314

💛 - Coveralls

@ragavendra
Copy link
Contributor Author

instead of installing chai, we can just drop line 3 and change those to.equal to toEqual

I agree, I wonder why I didn't see it the first time and went on add it .....

we don't need to change the lock file tho

sure ....

@kamilmysliwiec kamilmysliwiec merged commit 783e833 into nestjs:master Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants