fix(sample): make sample 34 test resilient to external package changes #15835
+5
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sample 34 E2E test fails with
superjson2.2.3 due to exact JSON string matchingSample 34's purpose is to demonstrate ESM package import, not to validate
superjson's serialization format.superjson 2.2.3 was published to npm on Oct 22, 2025 (06:20 UTC), and CI tests started failing immediately after. The package added a "v": 1 field to the meta object for backward compatibility
Root Cause
superjson2.2.3 added internal version field for backward compatibility (PR #311)Issue Number: #15834
What is the new behavior?
Changed test from exact JSON string matching to object comparison
Does this PR introduce a breaking change?
Other information
Related
Alternatives considered