Parse attrib-bits field when its included in file attributes #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The attrib-bits field was introduced in V05 of the SFTP spec and needs to be parsed from the attributes struct when parsing file data. Without handling attrib-bits, we wind up off by 4 bytes for each entry in the filename data and quickly wind up parsing gibberish.
|
@bschmeck thanks looks great to me. Does it makes sense to add tests too?! |
|
Sorry for the delay here, I got pulled into other things and then went on vacation. I realized that version 6 also has an attributes bits field, so I reworked things slightly and now I also added test for the new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 5 of the SFTP spec introduced an optional
attrib-bitsfield (spec). When a server returns that data and we don't handle the 4 byte field, we quickly wind up parsing gibberish. (In my case, I wound up looping forever over a non-existent ACL entry and OOM'd my box.)Changes between v4 and v5: https://datatracker.ietf.org/doc/html/draft-ietf-secsh-filexfer-05#section-10.1
v5 file attributes struct definition: https://datatracker.ietf.org/doc/html/draft-ietf-secsh-filexfer-05#section-5