Support custom SSL certificates for the dashboard #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Force-pushed to fix authorship |
6 tasks
|
When that PR will be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the init_cert.sh script in the docker container to support using custom SSL certificates.
I've added two env-vars,
NGINX_SSL_CERTandNGINX_SSL_KEY, which when set, will configure the nginx default.conf with the provided port and certificate paths. WhenLETSENCRYPT_DOMAINis set,NGINX_SSL_CERTandNGINX_SSL_KEYare ignored.I've also made it so that the dashboard port can be changed without providing certificates. This way, setting
NGINX_SSL_PORTwill change the nginx listen port. It may be worth considering changing the env-var name.This partially closes netbirdio/netbird#2242