[management] Add MySQL Support by bcmmbaga · Pull Request #3108 · netbirdio/netbird

bcmmbaga · 2024-12-24T11:02:17Z

Describe your changes

Issue ticket number and link

Checklist

Is it a bug fix
Is a typo/documentation fix
Is a feature enhancement
It is a refactor
Created tests that fail without the change (if possible)
Extended the README / documentation, if necessary

* Update store.go * Update sql_store.go * Update store.go * Update golang-test-linux.yml * Update store.go * Update go.mod * Update go.mod * Update go.sum * Update store.go * Update sql_store.go * TestContainer * Update go.sum * Update store.go * TestUtil Duplicate * dsn fix * go mod tidy * NETBIRD_STORE_ENGINE_MYSQL_DSN * Skip Test * Update test-infrastructure-files.yml * Update test-infrastructure-files.yml * MYSQL_ROOT_PASSWORD added * Update test-infrastructure-files.yml * Update store.go * Debug + Mysql JSON Query * swicth/case convert * Update store.go * Update store.go * Debug * MySQL Test Version Change * Root Test * Ignore other sql tests. * MySQL Connection Fix * enable other tests * The word "key" is a reserved word in MySQL. * Remove Debugs * Update sql_store.go * Added default null value for datetime. * Added default null value for datetime. * MySQL Hooks * MySQL Config File * remove default values * test timeout change * MySQL max lifetime change * WithConfigFile * disable other tests * Update mysql.cnf * Update golang-test-linux.yml * Delete sql_hooks.go * enable other tests * test timeout change * update packets * Fix the Inactivity Expiration problem * Update sql_store.go * Update mysql.cnf * Update sql_store.go * Update sql_store.go * timeout change * MySQL Connection LifeTime Change * TestContainers have been optimized. * Update store_ios.go * Update sql_store.go * timeout fix * fix migration (setup keys) * Update event.go * Add disable option for event activities. * Revert "Update event.go" * Update event.go * Fix Gorm Mysql Bug * update go-jose module * containerd module update * containerd downgrade * Revert commits * Revert "Revert commits" This reverts commit 62b3eac. * Revert "containerd downgrade" This reverts commit 4e46108. * Revert "containerd module update" This reverts commit e8cfa87. * Revert "update go-jose module" This reverts commit 1fabdc7.

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

# Conflicts: # management/server/account.go # management/server/store/sql_store.go # management/server/store/store.go

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

ismail0234 · 2025-01-03T07:19:46Z

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

bcmmbaga · 2025-01-03T08:08:17Z

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

The current setup with MySQL works only when the SQL mode is not set, but with the default strict mode, it encounters issues. Some of the broken functionality includes adding new users, creating user PATs, creating new setup keys, and adding new peers. These additional commits aim to address these problems and ensure the MySQL test container runs in strict mode to verify everything works correctly and to catch any potential issues that could break MySQL support

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

ismail0234 · 2025-01-03T10:19:41Z

All of these commits are unnecessary. In the PR I have already opened, mysql is running without any problems. I don't understand why you send so many useless commits.

The current setup with MySQL works only when the SQL mode is not set, but with the default strict mode, it encounters issues. Some of the broken functionality includes adding new users, creating user PATs, creating new setup keys, and adding new peers. These additional commits aim to address these problems and ensure the MySQL test container runs in strict mode to verify everything works correctly and to catch any potential issues that could break MySQL support

It should not be difficult for users to set sql mode. I have been using the mysql engine in a production environment for 1 month. I have not encountered any problems so far.

250+ onlines
600+ peers

Performance is quite good.

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

sonarqubecloud · 2025-01-06T10:07:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.7% Duplication on New Code

See analysis details on SonarQube Cloud

ismail0234 and others added 4 commits December 23, 2024 13:06

Downgrade test containers to v0.31.0

f75af15

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Merge branch 'main' into feature/mysql-support

214b863

# Conflicts: # management/server/account.go # management/server/store/sql_store.go # management/server/store/store.go

fix merge

0daccae

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from a25e299 to 6a1db52 Compare December 24, 2024 13:51

Refactor tests containers

626b36f

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from 6a1db52 to 626b36f Compare December 24, 2024 14:03

Fix unknown mysql config file path

0422b36

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from c155d2b to 7328a0e Compare December 27, 2024 14:25

downgrade test containers

80d1bed

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from 7328a0e to 80d1bed Compare December 27, 2024 14:30

bcmmbaga added 4 commits December 27, 2024 18:06

Terminate tests containers on defer instead of waiting

3f30eb7

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Refactor and handle null time

0207a32

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Handle user lastLogin null time

9ee234a

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Revert caching test containers

1adab0d

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from b7da985 to 1adab0d Compare December 30, 2024 15:39

bcmmbaga marked this pull request as ready for review December 30, 2024 16:10

bcmmbaga added 2 commits January 2, 2025 14:54

Merge branch 'main' into feature/mysql-support

a3fe7be

Use time pointer instead of sql.NullTime

525019b

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from 4c4bc16 to 525019b Compare January 2, 2025 12:49

bcmmbaga added 3 commits January 2, 2025 16:49

Refactor pat to support mysql

79f94dd

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Use mysql memory instead of fs

7e3ff30

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Fix tests

c76683a

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from 64fa18f to c76683a Compare January 2, 2025 14:37

bcmmbaga added 2 commits January 2, 2025 17:41

Merge branch 'main' into feature/mysql-support

2028cbd

Fix merge

265b042

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from 0b9d596 to 265b042 Compare January 2, 2025 16:15

mlsmaycon added 3 commits January 3, 2025 00:58

update test sql files and use warmed container

47ac30b

sync go.mod

69a5b24

sync go.mod

1445e7a

mlsmaycon added 4 commits January 3, 2025 01:27

use mlsmaycon/warmed-mysql

154d08c

fix linter

f7b1a17

docker login

aa13b73

pull image with regular user

f1cea52

Fix tests

b740fef

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from dbe2d0f to b740fef Compare January 3, 2025 09:45

bcmmbaga added 7 commits January 3, 2025 14:27

Skip integration tests on mysql

60c50bf

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Terminate mysql container

6cccc97

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Release context and enable integration tests

7a6102f

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Refactor and fix sonar lint

34d26d4

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Prevent setting zero user last login

ca40247

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Merge branch 'main' into feature/mysql-support

8634871

Fix merge

b178e71

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from f517031 to b178e71 Compare January 3, 2025 15:07

Enable integration and benchmark for mysql

a49cccf

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

bcmmbaga force-pushed the feature/mysql-support branch from da944cb to a49cccf Compare January 3, 2025 16:54

bcmmbaga added 2 commits January 3, 2025 21:51

Adjust benchmark expectations

c8b82b7

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

Refactor user lastlogin update

c29f84f

Signed-off-by: bcmmbaga <bethuelmbaga12@gmail.com>

mlsmaycon approved these changes Jan 6, 2025

View reviewed changes

mlsmaycon merged commit 02a3fed into main Jan 6, 2025

mlsmaycon deleted the feature/mysql-support branch January 6, 2025 12:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[management] Add MySQL Support#3108

[management] Add MySQL Support#3108
mlsmaycon merged 36 commits intomainfrom
feature/mysql-support

bcmmbaga commented Dec 24, 2024

Uh oh!

ismail0234 commented Jan 3, 2025

Uh oh!

bcmmbaga commented Jan 3, 2025

Uh oh!

ismail0234 commented Jan 3, 2025

Uh oh!

sonarqubecloud Bot commented Jan 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bcmmbaga commented Dec 24, 2024

Describe your changes

Issue ticket number and link

Checklist

Uh oh!

ismail0234 commented Jan 3, 2025

Uh oh!

bcmmbaga commented Jan 3, 2025

Uh oh!

ismail0234 commented Jan 3, 2025

Uh oh!

sonarqubecloud Bot commented Jan 6, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants