Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update boot.cfg.j2 #1477

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

sparky3387
Copy link

Allow users to set their own values for win_base_url and rhel_base_url from local-vars

This is to resolve the following bug (by allowing users to set their own win_base_url)

#1344

Allow users to set their own values for win_base_url and rhel_base_url from local-vars
@tomlawrence
Copy link

I was looking to achieve the same goal of using local-vars.ipxe to set win_base_url and realized it was being blanked by boot.cfg which is chained by menu.ipxe, defaulting the value to an empty string and removing any previous value set. I was going to commit something with an {% if win_base_url is defined %} statement but using isset seems cleaner!

@deffcolony
Copy link

@sparky3387 This would be nice, as I’ve been dealing with this issue for months now.

I’m new to Docker and would really appreciate some guidance on how to implement and run your fix using Docker Compose. Specifically, I’d like to understand the steps needed to:

  1. Pull your changes into my local setup.
  2. Configure win_base_url and rhel_base_url using local-vars.
  3. Run everything using Docker Compose.

I assume I’ll need to build the Docker image myself rather than simply pulling it from the docker-compose.yml file (which currently references image: lscr.io/linuxserver/netbootxyz:latest).

Could you provide a simple walkthrough or instructions on how to apply this fix and ensure it runs smoothly with Docker Compose? This would save me a lot of time by automating the URL setup instead of having to enter it manually each time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants