Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set type of permission constraint to raw #1374

Merged
merged 2 commits into from
Jan 26, 2025

Conversation

dchiquito
Copy link
Contributor

According to https://netboxlabs.com/docs/netbox/en/stable/administration/permissions/, constraints can be either a dictionary or a list of dictionaries. The only way to represent this in Ansible is with the raw type.

Related Issue

#1373

New Behavior

Update the constraint field type from list to raw.

Discussion: Benefits and Drawbacks

There is no way to specify multiple constraints without this change. There is also no way to specify the type more precisely, at least according to https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec

Changes to the Documentation

I believe the generated docs will need to be regenerated, but no manual changes are required.

Proposed Release Note Entry

Update type of permission constraint from list to raw

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

According to https://netboxlabs.com/docs/netbox/en/stable/administration/permissions/,
constraints can be either a dictionary or a list of dictionaries. The
only way to represent this in Ansible is with the `raw` type.
@rodvand rodvand merged commit b712398 into netbox-community:devel Jan 26, 2025
59 of 63 checks passed
@dchiquito dchiquito deleted the permission-constraint-type branch January 27, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants