Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1127: Added sentry-sdk to requirements #1166

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Fix #1127: Added sentry-sdk to requirements #1166

merged 1 commit into from
Mar 27, 2024

Conversation

tobiasge
Copy link
Member

Related Issue: #1127

New Behavior

  • Sentry can be used without building a new image

Contrast to Current Behavior

Discussion: Benefits and Drawbacks

  • sentry-sdk was previously a default requirement of Netbox itself. This was changed in version 3.7.

Changes to the Wiki

  • None

Proposed Release Note Entry

  • Added sentry-sdk back after it was not a default requirement anymore

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge tobiasge requested a review from cimnine February 23, 2024 07:13
@tobiasge tobiasge enabled auto-merge February 23, 2024 07:13
@tobiasge tobiasge disabled auto-merge March 27, 2024 13:44
@tobiasge tobiasge merged commit 9f009c5 into netbox-community:develop Mar 27, 2024
9 checks passed
@tobiasge tobiasge deleted the sentry-sdk branch March 27, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cimnine cimnine Awaiting requested review from cimnine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobiasge