Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved image build #1386

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improved image build #1386

wants to merge 1 commit into from
+13 −14

Conversation

tobiasge
Copy link
Member

Related Issue: #1385, #1383

New Behavior

  • Use uv as package manager to install Python dependencies
  • Set DEBUG = true when collecting static files is needed for a functional Django debug toolbar

Discussion: Benefits and Drawbacks

  • Faster builds
  • Django debug tool working

Changes to the Wiki

  • Th pages where we mention the use of pip need to be changed

Proposed Release Note Entry

Double Check

  • I have read the comments and followed the PR template.
  • I have explained my PR according to the information in the comments.
  • My PR targets the develop branch.

@tobiasge
Copy link
Member Author

Because the fix for netbox-community/netbox#18515 is only in Netbox main branch most tests will fail at the moment.

@jscooksey jscooksey mentioned this pull request Jan 29, 2025
Open
cimnine
cimnine approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@cimnine cimnine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise lgtm.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
ryanmerolle
ryanmerolle approved these changes Feb 1, 2025
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ryanmerolle
Copy link
Contributor

Everything really looks great... you beat me to introducing uv.

@tobiasge tobiasge force-pushed the uv-build branch 3 times, most recently from 3f69a89 to 3acfd25 Compare February 4, 2025 19:04
@tobiasge
Improved image build
542538b 
- Fix netbox-community#1383: Setting DEBUG = true when collection the static files
  enables the use of the Django debug toolbar.
- Fix netbox-community#1385: Use uv as package manager instead of pip speeds up the build.
- Nice display of Docker image version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanmerolle ryanmerolle ryanmerolle approved these changes

@cimnine cimnine cimnine approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tobiasge @ryanmerolle @cimnine