Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded controller tools and removed rbac-proxy for metrics endpoint #205

Merged
merged 3 commits into from
Jan 20, 2025
Merged

upgraded controller tools and removed rbac-proxy for metrics endpoint #205

merged 3 commits into from
Jan 20, 2025

Conversation

faebr
Copy link
Contributor

@faebr faebr commented Jan 14, 2025

No description provided.

@faebr faebr requested a review from bruelea January 14, 2025 18:31
bruelea
bruelea requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@bruelea bruelea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Only noticed, that some labels got relevant for matching the metrics service only to the netbox-operator pod got removed.

config/prometheus/monitor.yaml Show resolved Hide resolved
@faebr faebr merged commit 40b001d into main Jan 20, 2025
8 checks passed
@faebr faebr deleted the feature/upgrade-kubebuilder branch January 20, 2025 16:02
@faebr faebr mentioned this pull request Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruelea bruelea bruelea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faebr @bruelea