[CI] Do not cancel concurrent CI jobs on main #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we merge a PR into the main branch before the previously merged commit finishes, the CI jobs will be cancelled, which is not ideal as we would like to see if all commits merged into main can pass CI checks.
henrybear327
commented
Jan 27, 2025
| @@ -9,7 +9,7 @@ on: | |||
| pull_request: | |||
| concurrency: | |||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | |||
| cancel-in-progress: true | |||
| cancel-in-progress: ${{ !contains(github.ref, 'main/')}} | |||
There was a problem hiding this comment.
The same should be added for v* in the case where we do releases in quick succession (which shouldn't happen), but I haven't figured out how so far, thus leaving this out but noting it down here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we merge a PR into the main branch before the previously merged commit finishes, the CI jobs will be cancelled (see https://github.com/netbox-community/netbox-operator/commits/main/), which is not ideal as we would like to see if all commits merged into the main branch can pass CI checks.