16640 fix JSON custom field save nul #16713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Jun 25, 2024
| @@ -39,7 +39,7 @@ def _get_form_field(self, customfield): | |||
| form_field = customfield.to_form_field(set_initial=False) | |||
| initial = self.instance.custom_field_data.get(customfield.name) | |||
| if customfield.type == CustomFieldTypeChoices.TYPE_JSON: | |||
| form_field.initial = json.dumps(initial) | |||
| form_field.initial = json.dumps(initial) if initial else '' | |||
There was a problem hiding this comment.
I think we need to check against None explicitly, because e.g. 0 would be a valid value.
Suggested change
| form_field.initial = json.dumps(initial) if initial else '' | |
| form_field.initial = json.dumps(initial) if initial is not None else '' |
There was a problem hiding this comment.
But that wouldn't be valid JSON, I think you have to have key:value for valid JSON which would never evaluate to False?
There was a problem hiding this comment.
AFAIK you can store arbitrary scalars like 123 or "foo" in the field too.
|
Hi all, I am the reported of the original issue. This PR appears to fix the issue for null values only. Editing existing values, or creating a prefix with a default value both lead to escaped strings being placed in the field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16640
This will fix new saves, doesn't go back and fix old values - could set it to UI editable and edit it to fix. If you have saved multiple times then it will keep escaping so not sure if more dangerous to auto-fix with a validate as JSON and if not valid then revert to ''...