Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211

Merged
merged 20 commits into from
Feb 26, 2025
+292 −15
Merged

Fixes: #15924 - Prevent API payload from allowing tagged_vlans while interface mode is set to tagged-all #17211

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
5c9a145
Fixes: #15924 - Prevent API payload from allowing tagged_vlans while …
DanSheps Aug 20, 2024
282836c
Prevent cleanup of tagged_vlans when no tagged_vlans set on interface
DanSheps Aug 20, 2024
4ea0047
Fix test errors
DanSheps Aug 20, 2024
d4c8e88
Remove accidental debug statements
DanSheps Aug 22, 2024
bab5a5b
Update validation to model clean method instead of serializer
DanSheps Aug 25, 2024
4f830ce
Remove clearing of tagged vlans from `save()`
DanSheps Aug 25, 2024
d159547
Make changes to validation to account for M2M not being available und…
DanSheps Aug 27, 2024
9a13caa
Optimize untagged vlan check
DanSheps Aug 27, 2024
07444e6
Re-ordering statements in validators
DanSheps Aug 27, 2024
5776db6
Forgot to call super().clean()
DanSheps Aug 27, 2024
140d552
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps Sep 23, 2024
1789862
Adjust logic for form and serializer. Add tests
DanSheps Sep 23, 2024
8dd6119
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps Oct 17, 2024
365e2fb
Fix test failure
DanSheps Oct 17, 2024
afb748c
Merge branch 'feature' of https://github.com/netbox-community/netbox …
DanSheps Jan 20, 2025
e858706
Fix ruff errors
DanSheps Jan 20, 2025
79262c6
Fix test by removing now invalid test
DanSheps Jan 21, 2025
8ee5d0a
Update serializer, form and tests
DanSheps Feb 24, 2025
2c08258
Optimize API test for vlan fields
DanSheps Feb 25, 2025
41e6a55
Optimize API serializer logic
DanSheps Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'feature' of https://github.com/netbox-community/netbox … 
…into 15924-fix-api-interface-patch-tagged-all-mode
@DanSheps
DanSheps committed Sep 23, 2024
commit 140d552a54d6a44c3f1c9924854414426b234f61

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.