Closes #7598: Enable custom field filtering for GraphQL #18701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeremy Stretch <[email protected]>
* Add as_num() method to ChoiceSet * Update circuits enums * Update DCIM enums * Update extras enums * Update IPAM enums * Add tenancy enums * Update virtualization enums * Update VPN enums * Update wireless enums * Update netbox enums * Permit TenantType.group to be null
|
We still need to update the documentation to cover:
|
|
I believe this PR also resolves the following bugs related to GraphQL functionality: |
|
We have continued using this graphql filtering system on 4.0.11 and have reduced nested queries that were taking 36s with pynetbox and the DRF API to 400ms with graphql. The additional changes you have made look good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #7598
This PR serves to capture @jeremypng's recent work on improving the GraphQL API. Although this work primarily targets FR #7598, it includes many foundational improvements:
USE_DEPRECATED_FILTERS = False)as_enum()method to ChoiceSet for use in GraphQL filters