Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15924: Fix API interface patch tagged all mode #18759

Merged
merged 20 commits into from
Feb 28, 2025

Conversation

jeremystretch
Copy link
Member

@jeremystretch jeremystretch commented Feb 27, 2025

Fixes: #15924

  • Prevent API (or any API write function) which includes untagged_vlan with interface 802.1q mode is not set
  • Prevent API (or any API write function) which includes tagged_vlans with interface mode set to tagged-all

Note: These changes were initially merged into feature as it was understood to effect a breaking change, however after some discussion we decided that was not warranted, so we're merging these into main now for NetBox v4.2.

@jeremystretch jeremystretch merged commit 63a167f into main Feb 28, 2025
9 checks passed
@jeremystretch jeremystretch deleted the 15924-fix-api-interface-patch-tagged-all-mode branch February 28, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Interface.tagged_vlans via API improperly allowed on interface with mode: tagged-all
3 participants