-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #15924: Fix API interface patch tagged all mode #18759
Merged
jeremystretch
merged 20 commits into
main
from
15924-fix-api-interface-patch-tagged-all-mode
Feb 28, 2025
Merged
Fixes #15924: Fix API interface patch tagged all mode #18759
jeremystretch
merged 20 commits into
main
from
15924-fix-api-interface-patch-tagged-all-mode
Feb 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…interface mode is set to taged-all
…er model in addition to not being able to check incoming vlans under same model.
…into 15924-fix-api-interface-patch-tagged-all-mode
…into 15924-fix-api-interface-patch-tagged-all-mode
…into 15924-fix-api-interface-patch-tagged-all-mode
arthanson
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15924
untagged_vlan
with interface 802.1q mode is not settagged_vlans
with interface mode set to tagged-allNote: These changes were initially merged into
feature
as it was understood to effect a breaking change, however after some discussion we decided that was not warranted, so we're merging these intomain
now for NetBox v4.2.