Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #17608: Adds L2VPN.status field #18791

Open
wants to merge 8 commits into
base: feature
Choose a base branch
from
Open

Closes #17608: Adds L2VPN.status field #18791

wants to merge 8 commits into from

Conversation

jnovinger
Copy link
Contributor

Fixes: #17608

  • adds L2VPN.status field with L2VPNStatusChoices as choices
  • adds migration for L2VPN.status
  • updates forms and filtersets for L2VPN.status
  • updates UI views (tables and detail template) and API serializer for L2VPN.status
  • updates L2VPNIndex to display status in results
  • fixes tests to use new L2VPN.status field

@jnovinger jnovinger marked this pull request as draft March 3, 2025 17:47
@jnovinger jnovinger marked this pull request as ready for review March 3, 2025 18:11
@jnovinger jnovinger requested review from a team and arthanson and removed request for a team March 3, 2025 18:11
@jnovinger
Copy link
Contributor Author

@arthanson , since you won the review lottery: any guidance on what types of fields should be added to a model's clone_fields attribute?

@jnovinger
Copy link
Contributor Author

jnovinger commented Mar 3, 2025 •
edited
Loading

Doh, just realized I forgot to update the model docs. Will get that momentarily. Done

@jnovinger
Updates vpn.L2VPN docs
a63b52d 
Also rearranges L2VPNStatusChoices so that the default value (active) is
first.
@jnovinger jnovinger changed the title Closes #17608: adds L2VPN.status field Closes #17608: Adds L2VPN.status field Mar 3, 2025
jnovinger
jnovinger commented Mar 3, 2025
View reviewed changes
netbox/vpn/choices.py

STATUS_ACTIVE = 'active'
STATUS_PLANNED = 'planned'
STATUS_DECOMMISSIONED = 'decommissioned'
Copy link
Contributor Author

@jnovinger jnovinger Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be STATUS_DECOMMISSIONING ... like other choice sets for the sake of consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthanson arthanson Awaiting requested review from arthanson arthanson was automatically assigned from netbox-community/netbox-core-reviewers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnovinger