Conversation
ab88ee4 to
a2c9cdb
Compare
|
@claude /review Only report on issues of potential concern; we don't need commentary on anything that doesn't require further consideration. |
|
Claude finished @pheus's task in 2m 39s —— View job Code ReviewOne potential concern: Coverage accuracy with The "Run tests with coverage" step uses Django's - name: Run tests with coverage
if: ${{ matrix.coverage }}
run: >-
coverage run --source="netbox/"
netbox/manage.py test netbox/ --parallelWhen Django's parallel test runner is active, test work is distributed across subprocess workers (via Additionally, there is no To get accurate coverage, one of:
Option 1 is simpler but slower; option 2 preserves parallel speed at the cost of extra configuration. Everything else — the matrix |
|
This PR keeps that behavior unchanged and only limits the existing coverage run to a single matrix entry, which is the scope of #22093. So while the coverage accuracy concern may be real, I don’t think this PR introduces the issue or should expand to solve it. I’ll open a separate housekeeping issue to track improving coverage collection for parallel test runs. |
Add explicit CI job names showing the Python and Node versions, with the coverage job clearly marked in the GitHub Actions UI. Run coverage only for the designated coverage matrix entry to avoid redundant coverage collection and reporting across the full test matrix. Also add the YAML document marker and clean up trailing whitespace. Fixes #22093
a2c9cdb to
34f74ab
Compare
Fixes: #22093
Add explicit CI job names showing the Python and Node versions, with the coverage job clearly marked in the GitHub Actions UI.
Run coverage only for the designated coverage matrix entry to avoid redundant coverage collection and reporting across the full test matrix.
Also add the YAML document marker and clean up trailing whitespace.