Skip to content

feat: add interface description mapping for snmp discovery #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+23 −0
Open

feat: add interface description mapping for snmp discovery #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions snmp-discovery/mapping/mappers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,13 @@ func (m *InterfaceMapper) Map(values map[ObjectIDIndex]*ObjectIDValue, mappingEn
case "name":
interfaceEntity.Name = &value.Value
fieldFound = true
case "description":
description := strings.TrimRight(value.Value, " \t\n\r")
if len(description) > 200 {
description = description[:197] + "..."
}
interfaceEntity.Description = &description
fieldFound = true
case "type":
defaultType := ""
if defaults != nil && defaults.Interface.Type != "" {
Expand Down
13 changes: 13 additions & 0 deletions snmp-discovery/mapping/mappers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,13 @@ func TestInterfaceMapper_Map(t *testing.T) {
Value: "1",
Type: mapping.Integer,
},
"1.3.6.1.2.1.31.1.1.1.18.1": {
OID: "1.3.6.1.2.1.31.1.1.1.18.1",
Index: "1",
Parent: "1.3.6.1.2.1.31.1.1.1.18",
Value: "uplink interface",
Type: mapping.OctetString,
},
},
mappingEntry: &mapping.Entry{
OID: "1.3.6.1.2.1.2.2.1.1",
Expand Down Expand Up @@ -424,6 +431,11 @@ func TestInterfaceMapper_Map(t *testing.T) {
Entity: "interface",
Field: "adminStatus",
},
{
OID: "1.3.6.1.2.1.31.1.1.1.18",
Entity: "interface",
Field: "description",
},
},
},
defaults: nil,
Expand All @@ -433,6 +445,7 @@ func TestInterfaceMapper_Map(t *testing.T) {
Mtu: int64Ptr(1500),
PrimaryMacAddress: &diode.MACAddress{MacAddress: mapping.StringPtr("00:11:22:33:44:55")},
Enabled: boolPtr(true),
Description: mapping.StringPtr("uplink interface"),
},
expectError: false,
},
Expand Down
3 changes: 3 additions & 0 deletions snmp-discovery/policy/mapping.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ entries:
- oid: ".1.3.6.1.2.1.2.2.1.7"
entity: "interface"
field: "adminStatus"
- oid: ".1.3.6.1.2.1.31.1.1.1.18"
entity: "interface"
field: "description"

# IP Address mappings
- oid: ".1.3.6.1.2.1.4.20.1"
Expand Down
Loading