Huaccho #156
Huaccho #156
Conversation
|
|
||
| for line in lines: | ||
| stripped_line = line.strip() | ||
| stripped_line: str = line.strip() |
There was a problem hiding this comment.
I typically don't gratuitously add type annotations to variables unless there's some ambiguity pointed out by pyright/mypy --strict. Is there an argument for this practice?
There was a problem hiding this comment.
I add type annotations to variables to be explicit. It aides the IDE and shows intent, so developers know to keep this variable as this same or compatible type. I understand why omitting type annotation here would be preferred. I can remove this if this is the practice you decide to keep
|
|
||
| [tool.ruff.lint.per-file-ignores] | ||
| "**/tests/*" = ["PLC2701", "S101"] | ||
| "**/tests/*" = ["PLC2701", "S101"] |
There was a problem hiding this comment.
Please add back the new line at the end of the file
There was a problem hiding this comment.
I didn't remove the new line here, in my IDE I can see a trailing new line in pyrpoject.toml. I'm not entirely sure why this diff was found
2 participants
Adding some documentation to the code. Would like to add more, but I believe this is a good spot to ask for feedback on changes or suggestions