Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NGSTACK-843 page indexing implementation from fina + FieldMapper impl… #10

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open

NGSTACK-843 page indexing implementation from fina + FieldMapper impl… #10

wants to merge 48 commits into from

Conversation

kmiocic
Copy link

@kmiocic kmiocic commented Apr 15, 2024

…ementation for elasticsearch

@kmiocic kmiocic requested a review from pspanja April 15, 2024 13:06
@kmiocic kmiocic force-pushed the NGSTACK-843-layout-indexing branch 2 times, most recently from 22d61fa to c1548a8 Compare April 22, 2024 10:20
@kmiocic kmiocic changed the title NGSTACK-834 page indexing implementation from fina + FieldMapper impl… NGSTACK-843 page indexing implementation from fina + FieldMapper impl… Apr 25, 2024
pspanja
pspanja reviewed May 9, 2024
View reviewed changes
lib/Container/Compiler/ElasticsearchExtensibleDocumentFactoryPass.php
/**
* This compiler pass will register elastic search field mappers.
*/
final class ElasticsearchExtensibleDocumentFactoryPass implements CompilerPassInterface
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this can be moved to YAML configuration - it should be always active.

pspanja
pspanja reviewed May 9, 2024
View reviewed changes
lib/Core/Search/Common/PageTextExtractor/PageTextExtractor.php Outdated
use const XML_HTML_DOCUMENT_NODE;
use const XML_TEXT_NODE;

class PageTextExtractor extends \Netgen\IbexaSearchExtra\Core\Search\Common\PageTextExtractor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to NativePageTextExtractor.

pspanja
pspanja reviewed May 9, 2024
View reviewed changes
lib/Core/Search/Common/PageTextExtractor/PageTextExtractor.php Outdated
*/
public function extractPageText(int $contentId, string $languageCode): array
{
$siteConfig = $this->siteAccessConfigResolver->getSiteConfigForContent($contentId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be moved below cache checks as it's not needed before.

@pspanja
Copy link
Member

pspanja commented May 9, 2024

@kmiocic please integrate code style from Site API and apply it on the affected files here. We will eventually need to apply it to the whole codebase, but that's too big a change for this PR and will need to be done separately: https://github.com/netgen/ibexa-site-api/blob/master/.php-cs-fixer.php

pspanja
pspanja reviewed May 10, 2024
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@kmiocic kmiocic force-pushed the NGSTACK-843-layout-indexing branch from efd39bc to e5248c7 Compare May 10, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pspanja pspanja pspanja left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmiocic @pspanja