Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency inquirer to v8 #3960

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 6, 2022

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
inquirer ^6.5.1 -> ^8.0.0 age adoption passing confidence

Release Notes

SBoudrias/Inquirer.js

v8.2.0

Compare Source

  • checkbox prompt: Update the help message to be more complete. And the help message is now shown until a selection is made.

v8.1.5

Compare Source

Fix older Node version compatibility issue.

v8.1.4

Compare Source

  • Fix an error being thrown inside the rawlist prompt

v8.1.3

Compare Source

Bug Fixes
  • Fix password prompt appearing when doing async filtering/validation
  • User being prompted a question even though it was answered when using nested answer object format.
  • Fix extra space appearing when using custom prefix.

And bump of all dependencies.

v8.1.2

Compare Source

  • Fix bug on rawList prompt
  • Bump dependencies

v8.1.1

Compare Source

Fix: Number prompt default behavior.

v8.1.0

Compare Source

New features
  • Now display a loading spinner while asynchronously filtering or validating data.
  • inquirer.prompt() now accept a shorthand object syntax instead of an array with named prompts:
const { foo, bar } = await inquirer.prompt({
  foo: {
    message: '...',
    default: '...',
  },
  bar: {
    default: '...',
  }
}):

v8.0.1

Compare Source

Fixes

  • Fix issue with duplicate keys in expand prompt not being caught if casing didn't match
  • Fix rawlist prompt ignoring short option
  • Rollback dependencies migrated to ESM causing issue for some users

And lastly general dependency upgrade (to non-ESM versions)

v8.0.0

Compare Source

  • Drop support for Node 10 (through dependencies)
  • Add postfix option to the editor prompt to allow easily turning on proper syntax highlighting

v7.3.3

Compare Source

  • Fix to release the readline on errors
  • Security patch (lodash)

v7.3.2

Compare Source

Fix the loop: false option in the checkbox prompt.

v7.3.1

Compare Source

  • Fix the loop: false option in the list prompt.

v7.3.0

Compare Source

  • New option loop (boolean) for list type prompts. This prevents the list from looping when reaching the top or bottom of the selection.
  • Bug fix: multi line list type prompts
  • Core: Bumped dependencies

v7.2.0

Compare Source

Enhancement
Bug Fix

v7.1.0

Compare Source

v7.0.7

Compare Source

v7.0.6

Compare Source

v7.0.5

Compare Source

Errors when running in non-TTY environment are now marked and catchable.

v7.0.4

Compare Source

v7.0.3

Compare Source

Revert broken fix done in 7.0.2

v7.0.2

Compare Source

~Work around bug affecting Windows user with Node 10 (#​767)~ (Reverted in v7.0.3)

v7.0.1

Compare Source

v7.0.0

Compare Source

  • Drop support for Node 6.

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

📊 Benchmark results

Comparing with afdf556

Package size: 371 MB

⬆️ 3.30% increase vs. afdf556

^                                                                                                  371 MB 
│  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB  359 MB   ┌──┐  
│ ──┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────┌──┐────|▒▒|──
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@erezrokah
Copy link
Contributor

This change is OK, but it raises our package size quite a bit.
The reason is that npm can no longer dedupe inquirer as we have another dependency that uses v6.
See mklabs/tabtab#77

@erezrokah erezrokah closed this Jan 7, 2022
@erezrokah erezrokah deleted the renovate/inquirer-8.x branch January 7, 2022 10:59
@renovate
Copy link
Contributor Author

renovate bot commented Jan 7, 2022

Renovate Ignore Notification

As this PR has been closed unmerged, Renovate will ignore this upgrade and you will not receive PRs for any future 8.x releases. However, if you upgrade to 8.x manually then Renovate will reenable minor and patch updates automatically.

If this PR was closed by mistake or you changed your mind, you can simply rename this PR and you will soon get a fresh replacement PR opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants