-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop re-exporting exports removed in [email protected] #459
fix: stop re-exporting exports removed in [email protected] #459
Conversation
✅ Deploy Preview for remix-serverless ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for remix-edge ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
These unstable functions and types were removed in remix-run/remix#9893. Since they were clearly named `unstable_` and Remix doesn't require major releases for changes to these, we'll do the same thing.
f40a954
to
ddfa2d8
Compare
unstable_setDevServerHooks, | ||
UNSAFE_SingleFetchRedirectSymbol, | ||
} from '@remix-run/server-runtime' | ||
|
||
// TODO(serhalp) The docs say we should simply re-export all types from `/reexport`: | ||
// https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme. | ||
// Let's do that, but carefully verify whether this adds or removes any exports first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make a linear ticket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Would you mind doing that? Or we could just open a draft PR that does that (and removes the remaining unstable_
exports) and we'll keep track of if that way.
To get this fix: netlify/remix-compute#459.
To get this fix: netlify/remix-compute#459.
Description
Some "unstable" functions and types were removed in remix-run/remix#9893.
Since they were clearly named
unstable_
and Remix doesn't require major releases for changes to these, we'll do the same thing here.We should probably just not export any
unstable_
e xports. Remix doesn't actually require that server runtime implementations export these: https://github.com/remix-run/remix/tree/main/packages/remix-server-runtime#readme.Related Tickets & Documents
Closes #458, which actually affects both Remix and Hydrogen.
QA Instructions, Screenshots, Recordings
N/A - just bumps remix dev dep and fixes type errors