Allow return of labelids in find_parcel_centroids #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds optional boolean flag (get_labelids) which, if True, causes find_parcel_centroids to return a 1D ndarray of labels corresponding to the centroids.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working with an atlas (Brainnetome) that interleaves nodes from each hemisphere (e.g.
1=L, 2=R, 3=L, 4=R, ...).find_parcel_centroidsseparates the two hemispheres in its return, such that all nodes from the left hemisphere come first, followed by the right. This disrupts the order of the nodes to something like (1, 3, 5, 7, ..., 2, 4, 6, 8, ...)To remedy this, I added a flag allowing the return of the label ids associated with each centroid, which in turn can be used to resort everything. The flag is
Falseby default, so there's no breaking change in behaviour.If you're interested in incorporating this, I'm happy to provide any tests as required, and any additional documentation (although this PR already updates the docstring).