Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1886: Networking events blog #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Sep 19, 2024

Adding blog for network events monitoring feature

@msherif1234 msherif1234 changed the title Initial draft for networking events blog NETOBSERV-1886: Initial draft for networking events blog Sep 19, 2024
@msherif1234 msherif1234 force-pushed the network_events branch 4 times, most recently from 6eec336 to f09f166 Compare September 23, 2024 15:47
@msherif1234 msherif1234 force-pushed the network_events branch 2 times, most recently from 10524f3 to 9b3a8b7 Compare October 4, 2024 16:46
Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions 😄

blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog, @msherif1234 ! I left some copy edits and suggestions for you. Let me know if you want to chat about any of it :) Thanks for letting me review!

blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
@msherif1234 msherif1234 changed the title NETOBSERV-1886: Initial draft for networking events blog NETOBSERV-1886: Networking events blog Oct 16, 2024
Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog! Thanks @msherif1234
A few comments, mostly nits

blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
Copy link

@npinaeva npinaeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great blog! Some minor suggestions

blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved
blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved

## Availability

The networking events monitoring feature is available as Developer Preview for OCP 4.17 z-stream and NetObserv release 1.7,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we say here the exact 4.17.z version when it is released?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is hard question as we don't know we probably will edit the blog once we have the exact release

Copy link
Contributor

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small suggestions

Also the screens could be better. What about showing only columns we are interested in ?
Date + SrcName + DestName + Event should be enough to showcase the usage

blogs/network_events/index.md Outdated Show resolved Hide resolved
blogs/network_events/index.md Show resolved Hide resolved
@msherif1234
Copy link
Contributor Author

LGTM, some small suggestions

Also the screens could be better. What about showing only columns we are interested in ? Date + SrcName + DestName + Event should be enough to showcase the usage

I am bit lazy to recapture all screens is there anything specific not good with the screen shots u want me to fix ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants