-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NETOBSERV-1886: Networking events blog #74
base: main
Are you sure you want to change the base?
Conversation
c5b11e8
to
e336f30
Compare
6eec336
to
f09f166
Compare
10524f3
to
9b3a8b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small suggestions 😄
9b3a8b7
to
f7837ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice blog, @msherif1234 ! I left some copy edits and suggestions for you. Let me know if you want to chat about any of it :) Thanks for letting me review!
f7837ed
to
9df39d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice blog! Thanks @msherif1234
A few comments, mostly nits
9df39d8
to
aed0023
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great blog! Some minor suggestions
|
||
## Availability | ||
|
||
The networking events monitoring feature is available as Developer Preview for OCP 4.17 z-stream and NetObserv release 1.7, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we say here the exact 4.17.z version when it is released?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is hard question as we don't know we probably will edit the blog once we have the exact release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some small suggestions
Also the screens could be better. What about showing only columns we are interested in ?
Date + SrcName + DestName + Event should be enough to showcase the usage
I am bit lazy to recapture all screens is there anything specific not good with the screen shots u want me to fix ? |
Signed-off-by: Mohamed Mahmoud <[email protected]>
aed0023
to
117fde3
Compare
Adding blog for network events monitoring feature