Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vue-template-compiler and i18next-parser in /web #564

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 23, 2024

Removes vue-template-compiler. It's no longer used after updating ancestor dependency i18next-parser. These dependencies need to be updated together.

Removes vue-template-compiler

Updates i18next-parser from 3.11.0 to 9.0.0

Release notes

Sourced from i18next-parser's releases.

8.0.0

  • BREAKING: Drop support for Node 14
  • Add support for Node 20

7.0.0

  • BREAKING: change the API for defaultValue. Deprecate skipDefaultValues and useKeysAsDefaultValues options. #676
  • Add support for shouldUnescape option in jsx-lexer #678
  • Add support for .ts, .json and .yaml config #673
  • Update dependencies

Migrating from 6.x to 7.x

he API to manage what default value is being used was getting too complicated. This version simplifies the API by deprecating the skipDefaultValues and useKeysAsDefaultValues options and adding a value argument when the defaultValue option is used as a function. Here are couple example of how it can be used:

To replace skipDefaultValue, make the following change:

// 5.x.x
{
  skipDefaultValues: true
}
// 6.x.x
{
defaultValue: function (locale, namespace, key, value) {
return '';
}
}

To replace useKeysAsDefaultValues, make the following change:

// 5.x.x
{
  useKeysAsDefaultValues: true
}
// 6.x.x
{
defaultValue: function (locale, namespace, key, value) {
return key;
}
}

And now you have complete control over the logic:

// 6.x.x
</tr></table> 

... (truncated)

Changelog

Sourced from i18next-parser's changelog.

9.0.0

8.13.0

  • Output the files in which a string is found in customValueTemplate #970
  • Fix babel dependency #976 #975
  • Update dependencies

8.12.0

  • Fix --fail-on-update false negatives from new sort code #957 #955
  • Update dependencies

8.11.0

  • Fix a bug where keepRemoved wasn't failing when the catalog get sorted #926 #932

8.10.0

  • Fix a bug where keepRemoved option makes the failOnUpdate fails without any update #948 #666
  • Update dependencies

8.9.0

  • Make tests work on Windows with non-English locale #931
  • Update dependencies

8.8.0

  • Handle attribute spreads #909 #908
  • Fix index.d.ts #919
  • Suppress warning about non-literal child when key/defaults are specified #900 #899
  • Support custom namespaced functions and components #913 #912
  • Update dependencies

8.7.0

  • Add missing componentFunctions properties to JsxLexerConfig types #891 #842
  • Fix unescape logic, expression props, and ICU format for Trans component #892 #886
  • Update dependencies

8.6.0

  • Emit warning on non-literal content inside of Trans #881
  • Update dependencies

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Removes [vue-template-compiler](https://github.com/vuejs/vue). It's no longer used after updating ancestor dependency [i18next-parser](https://github.com/i18next/i18next-parser). These dependencies need to be updated together.


Removes `vue-template-compiler`

Updates `i18next-parser` from 3.11.0 to 9.0.0
- [Release notes](https://github.com/i18next/i18next-parser/releases)
- [Changelog](https://github.com/i18next/i18next-parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/i18next/i18next-parser/commits)

---
updated-dependencies:
- dependency-name: vue-template-compiler
  dependency-type: indirect
- dependency-name: i18next-parser
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 23, 2024
Copy link

openshift-ci bot commented Jul 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kalmanmeth for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 23, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:cae6ebe

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=cae6ebe make set-plugin-image

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 9, 2024
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Sep 9, 2024
Copy link

github-actions bot commented Sep 9, 2024

New image:
quay.io/netobserv/network-observability-console-plugin:7287a82

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=7287a82 make set-plugin-image

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reject: it's breaking plural texts
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code needs-ok-to-test ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant