Dumper: print enum case directly in toPhp() #457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtech-dobes
force-pushed
the
toPhp-enum
branch
from
d4de75a to
b25d0df
Compare
vojtech-dobes
force-pushed
the
toPhp-enum
branch
from
b25d0df to
a465698
Compare
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Apr 3, 2025
dg
pushed a commit
that referenced
this pull request
Jun 5, 2025
dg
pushed a commit
that referenced
this pull request
Jun 19, 2025
dg
pushed a commit
that referenced
this pull request
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning: I was checking some test outputs and saw how enums get dumped, and was thinking if they were just simply inlined, the dump would be more readable.