Skip to content

Commit

Permalink
Adapt to netty5 HttpCookiePair API changes (#23)
Browse files Browse the repository at this point in the history
Motivation:

We need to adapt to the following netty5 PR, which introduces an API change regarding HttpCookiePair:

netty/netty#13516

Modifications:

the HttpUploadServerHandler in the example needs to be updated in order to parse the request Cookie header using `cookie.encodedCookie()` instead of `cookie.encoded()`

Results:

the codec-multipart project can now be built using latest netty 5.0.0.Alpha6-SNAPSHOT
  • Loading branch information
pderop committed Aug 28, 2023
1 parent 555fbe6 commit 17470ea
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ public void messageReceived(ChannelHandlerContext ctx, HttpObject msg) throws Ex

// new getMethod
for (HttpCookiePair cookie : request.headers().getCookies()) {
responseContent.append("COOKIE: " + cookie.encoded() + "\r\n");
responseContent.append("COOKIE: " + cookie.encodedCookie() + "\r\n");
}

responseContent.append("\r\n\r\n");
Expand Down

0 comments on commit 17470ea

Please sign in to comment.